Skip to content

Conversation

@jokonig
Copy link

@jokonig jokonig commented Oct 20, 2025

  • With ROOT v3.34, the functionality R__zipMultipleAlgorithm is not yet available, however R__zip also does not seem available.
  • A dummy function for R__zip is added in case the ROOT version is between 6.28 and 6.38. This means that the functionality of this function is lost in that cases.
  • Tested locally: AliRoot + AliPhysics build with the latest updated alidist + local train-tests were sucessful
  • This modifies what was implemented in: Add support for ROOT v6.36.00 #1525
  • Might not be the best solution! Please check!

- With ROOT v3.34, the functionality R__zipMultipleAlgorithm is not yet available, however R__zip also does not seem available.
- A dummy function for R__zip is added in case the ROOT version is between 6.28 and 6.38. This means that the functionality of this function is lost in that cases.
@alibuild
Copy link
Collaborator

c550533: approval required: 1 of @chiarazampolli (Chiara Zampolli), @davidrohr (David Rohr), @heikoengel (Heiko Engel), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @mkrzewic (Mikolaj Krzewicki), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @sawenzel (Sandro Christian Wenzel), @sgorbuno (Sergey Gorbunov), @shahor02 (Ruben Shahoyan)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

@ktf
Copy link
Member

ktf commented Oct 20, 2025

Can't you simply update to 6.36? it's now in production.

@jokonig
Copy link
Author

jokonig commented Oct 21, 2025

@ktf when you say its in production, does that mean these PRs (like alisw/AliPhysics#24074) will also go through automatically?
That would of course be ideal.

@jokonig
Copy link
Author

jokonig commented Oct 21, 2025

@ktf With the ROOT version 6.36 it still breaks. Looking at the open PRs, the log says "-- Found ROOT version 6.36.04"
However, the build fails with "undefined reference to `R__unzipMultipleAlgorithm'"
I honestly could not find out exactly since when the "R__unzipMultipleAlgorithm" is available. Maybe you know more on this?
Thanks for your help! :)

@pzhristov
Copy link
Collaborator

@jokonig @ktf I had a look in core/zip/inc/RZip.h. It seems R__unzipMultipleAlgorithm has never existed in Root, it was always R__unzip that was used. I'll provide a proper fix, make a PR and close this one.

@pzhristov
Copy link
Collaborator

@jokonig @ktf See #1527

@pzhristov pzhristov closed this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants